Fix CI with latest yard #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @jordanbreen28 as he authored the workaround and will probably be interested in a fix. |
|
@smortex nice workaround! can you take a look at the rubocop complaints? |
Monkey patching libraries is a bad idea. Latest version of yard changed some internal details, which broke CI. A workaround was proposed in puppetlabs#401 but the root cause was not addressed. In this commit, we replace the private `io` object with an instance of a class that provide the expected `IO#write` method instead of `nil` which does not provide this interface in CI, so that the issue is not raised anymore.
smortex
force-pushed
the
fix-ci-with-latest-yard
branch
from
b7a5d87 to
0eeb75d
Compare
Dang! Amended, thanks! Needs approval again to run CI 😁 |
|
Happy to press buttons for you! |
jordanbreen28
approved these changes
Nov 1, 2024
|
thanks @smortex!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monkey patching libraries is a bad idea. Latest version of yard changed
some internal details, which broke CI.
A workaround was proposed in #401 but the root cause was not addressed.
In this commit, we replace the private
ioobject with an instance of aclass that provide the expected
IO#writemethod instead ofnilwhichdoes not provide this interface in CI, so that the issue is not raised
anymore.